Adapt rust tests to test suite refactor #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgafni
approved these changes
Dec 27, 2024
danielgafni
force-pushed
the
refactor-pipes-tests
branch
from
385428e to
fe9d62a
Compare
|
Sorry @marijncv, could you please fix the conflict? I'll merge after that |
danielgafni
force-pushed
the
refactor-pipes-tests
branch
from
fe9d62a to
8ca8df7
Compare
No worries, should be fixed now! |
Really impressed by the work you two are doing. Going to merge this into |
cmpadden
pushed a commit
that referenced
this pull request
Jan 9, 2025
* [pipes] refactor Pipes tests interface * Adapt rust tests to test suite refactor (#81) * [pipes] refactor Pipes tests interface * adapt rust tests to test suite refactor --------- Co-authored-by: danielgafni <[email protected]> * add missing extras * Java tests refactoring (#84) * java tests refactoring --------- Co-authored-by: Marijn Valk <[email protected]> Co-authored-by: Andrey Grishchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This aligns the
Clistruct with the cli arguments passed in the test suiteHow I Tested These Changes
Changelog
Ensure that an entry has been created in
CHANGELOG.mdoutlining additions, deletions, and/or modifications.See: keepachangelog.com